chore: remove UnindexinedProject notification
#17395
Conversation
rustbot
added
the
S-waiting-on-review
davidbarsky
force-pushed
the
david/remove-unindexed-project-notification
branch
from
25300f1 to
46c3ffe
Compare
|
☔ The latest upstream changes (presumably #17455) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Just to check, is this resolved within#17246, or does this contain other changes (and just needs a rebase)? |
|
This one contains a few other changes and needs a rebase. I'll land it after monday's release in case there are any users of this. |
davidbarsky
force-pushed
the
david/remove-unindexed-project-notification
branch
from
46c3ffe to
7eff641
Compare
davidbarsky
force-pushed
the
david/remove-unindexed-project-notification
branch
2 times, most recently
from
5cef2c6 to
2040a95
Compare
|
|
||
| const RUST_PROJECT_CONTEXT_NAME = "inRustProject"; | ||
|
|
||
| // This API is not stable and may break in between minor releases. | ||
| export interface RustAnalyzerExtensionApi { |
There was a problem hiding this comment.
Let's keep the type itself just with the client property, that's what we used to have iirc
|
@bors delegate+ |
|
✌️ @davidbarsky, you can now approve this pull request! If @Veykril told you to " |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
davidbarsky
force-pushed
the
david/remove-unindexed-project-notification
branch
from
2040a95 to
2783aa7
Compare
|
☀️ Test successful - checks-actions |
Remove rust-analyzer.workspace.discoverProjectRunner The functionality for this vscode config option was removed in #17395, so it doesn't do anything anymore.
This PR is split out from #17246 (and contains its changes, which is a little annoying from a review perspective...). I'd like to land this change a week or so after #17246 lands in order to give any users of the unindexed project notification time to adopt migrate.