Skip to content

[VS Code Extension] Remap error location if it extracted inside macros #2575

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

edwin0cheng
Copy link
Member

It should fix for #2569

@edwin0cheng edwin0cheng changed the title Remap error location if it extracted inside macros [VS Code Extension] Remap error location if it extracted inside macros Dec 17, 2019
@kiljacken
Copy link
Contributor

Nice change, but CI is failing.

@matklad
Copy link
Member

matklad commented Dec 17, 2019

LGTM!

@edwin0cheng edwin0cheng force-pushed the fix-2569 branch 3 times, most recently from b3e6db1 to 2dce7ef Compare December 17, 2019 13:58
@edwin0cheng
Copy link
Member Author

edwin0cheng commented Dec 17, 2019

Block by #2583 :(

@edwin0cheng
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Dec 18, 2019
2575: [VS Code Extension] Remap error location if it extracted inside macros r=edwin0cheng a=edwin0cheng

It should fix for #2569






Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 18, 2019

Build succeeded

  • Rust
  • TypeScript

@bors bors bot merged commit bb9c60d into rust-lang:master Dec 18, 2019
@edwin0cheng edwin0cheng deleted the fix-2569 branch December 18, 2019 03:17
fannheyward added a commit to fannheyward/coc-rust-analyzer that referenced this pull request Dec 18, 2019
keeneyetact added a commit to keeneyetact/rust-see that referenced this pull request May 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants