Skip to content

Add YouCompleteMe as a LSP option for vim/neovim #4098

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add YouCompleteMe as a LSP option for vim/neovim #4098

merged 1 commit into from
Apr 23, 2020

Conversation

weihanglo
Copy link
Member

As YouCompleteMe supports arbitrary LSP implementation, it could be added to the list of vim LSP implementation. It works like a charm.

@matklad
Copy link
Member

matklad commented Apr 23, 2020

bors r+

Thanks!

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

@bors bors bot merged commit 1101e74 into rust-lang:master Apr 23, 2020
@flodiebold
Copy link
Member

Isn't YCM the one that doesn't support snippet completions? 😬

@matklad
Copy link
Member

matklad commented Apr 23, 2020

It is one, but it probably supports other features (like goto def), and having it in the manual makes fixing the underlying issue on our side more likely :)

@bstaletic
Copy link
Contributor

Isn't YCM the one that doesn't support snippet completions?

Yes, but since #4117, this isn't a showstopper (thanks to @matklad). Everything that I bothered to test worked as intended.

However, the link in this PR is bad, as it explains how to set RLS up. The rust-analyzer guide is here.

@matklad Do you want me to submit another PR to fix this?

@matklad
Copy link
Member

matklad commented Apr 29, 2020

@matklad Do you want me to submit another PR to fix this?

Yup, that would be helpful! To be fair, I just blindly merge all PRs regarding vim installation instructions without deep inspection, as I don't know a lot about them, and there are many options for vim.

@weihanglo
Copy link
Member Author

Sorry for the bad link. @bstaletic is right. We do not need --rust-completer flag for YCM setup because it would trigger the installation of rls.

@weihanglo weihanglo deleted the patch-1 branch April 29, 2020 10:38
bors bot added a commit that referenced this pull request Apr 29, 2020
4205: Fix YouComplteMe instructions link r=matklad a=bstaletic

Like I mentioned in #4098, the link to the instructions is for setting up RLS. This pull request fixes that mistake.

Co-authored-by: Boris Staletic <boris.staletic@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants