Make incremental sync opt-in #4286
Conversation
|
bors r+ Yeah, let's make this opt-in, and next week switch it to opt-out if we fail to find the issue ourselves. |
4286: Make incremental sync opt-in r=matklad a=lnicola @matklad do you want to merge this? I'd make it opt-out, but it's fine to test it more. 4287: Update debugging.md r=matklad a=lonesometraveler Co-authored-by: Laurențiu Nicola <lnicola@dend.ro> Co-authored-by: KENTARO OKUDA <lonesometraveler@mac.com>
|
bors retry |
|
Build succeeded: |
|
@matklad you should probably retrigger the nightly build. |
|
Hm, I haven't seen panics after the utf16 fix, and I now have a hypothesis that that might actually be a real fix:
So let's hope that everything is fine. We'll know for sure later today :D We need to enjoy the last opportunities to break things. Though, we still need to revert the opt-in, and we also need to implement "iterrate every char" test for line index. |
|
There might still be a bug in the tracking of line index validity range. I can't check right now, but I think we invalidate the lines below the edited range. The UTF-16 character list for the current line might also become invalid. I'll fix that when enabling it again.
XD. That's why I prefer per-window, not global, IME config. |
Hm, I think I should try this out -- originally I disliked it, because I was always confused about which language I am using right now, as the tray indication would just change when flipping the windows. However as of couple of years ago, I am using a custom layout, which just doesn't work with the tray indicator, so I got used to not knowing which layout is active at the moment :D |
…RalfJung Enable Non-determinism of float operations in Miri and change std tests Links to [rust-lang#4208](rust-lang/miri#4208) and [rust-lang#3555](rust-lang/miri#3555) in Miri. Non-determinism of floating point operations was disabled in rust-lang/rust#137594 because it breaks the tests and doc-tests in core/coretests and std. This PR enables some of them. This pr includes the following changes: - Enables the float non-determinism but with a lower relative error of 4ULP instead of 16ULP - These operations now have a fixed output based on the C23 standard, except the pow operations, this is tracked in [rust-lang#4286](rust-lang/miri#4286 (comment)) - Changes tests that made incorrect assumptions about the operations, not to make that assumption anymore (from `assert_eq!` to `assert_approx_eq!`. - Changed the doctests of the stdlib of these operations to compare against fixed constants instead of `f*::EPSILON`, which now succeed with Miri and `-Zmiri-many-seeds` - Added a constant `APPROX_DELTA` in `std/tests/floats/f32.rs` which is used for approximation tests, but with a different value when run in Miri. This is to make these tests succeed. - Added tests in the float tests of Miri to test the C23 behaviour. Fixes rust-lang/miri#4208
@matklad do you want to merge this? I'd make it opt-out, but it's fine to test it more.