Skip to content

internal: make rustdoc links spiky so they are clickable #9260

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Jun 14, 2021

Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed.

@matklad
Copy link
Member

matklad commented Jun 14, 2021

bors r+

Is not auto-linking a deliberate choice of rustdoc? Is there a an existing discussion about changing this behavior?

@bjorn3
Copy link
Member

bjorn3 commented Jun 14, 2021

Is not auto-linking a deliberate choice of rustdoc?

Yes: rust-lang/rust#71183 (comment), rust-lang/rust#77501

@lf-
Copy link
Contributor Author

lf- commented Jun 14, 2021

bors r+

Is not auto-linking a deliberate choice of rustdoc? Is there a an existing discussion about changing this behavior?

It seems like an odd choice, but there's a warning about not having auto links from the linting side of the compiler. Might be concern over ambiguity perhaps? I know that one of the bad cases of this is with parens in links, which are often seen in links to wikipedia.

All I could find about it was this: rust-lang/rust#81764

@bors
Copy link
Contributor

bors bot commented Jun 14, 2021

@bors bors bot merged commit 5a8ddb4 into rust-lang:master Jun 14, 2021
@lf- lf- deleted the spiky-links branch June 14, 2021 07:25
@lnicola lnicola changed the title tree-wide: make rustdoc links spiky so they are clickable internal: make rustdoc links spiky so they are clickable Jun 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants