Skip to content

internal: incentivize rust-analyzed developers to fix panics #9937

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 17, 2021

No description provided.

@matklad matklad marked this pull request as ready for review August 22, 2021 14:43
@matklad
Copy link
Member Author

matklad commented Aug 22, 2021

bors r+

bors bot added a commit that referenced this pull request Aug 22, 2021
9937: wip: pester devs to fix panics r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@matklad matklad changed the title wip: pester devs to fix panics internal: incentivize rust-analyzed developers to fix panics Aug 22, 2021
@matklad
Copy link
Member Author

matklad commented Aug 22, 2021

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 22, 2021

Canceled.

@matklad
Copy link
Member Author

matklad commented Aug 22, 2021

bors r+

It's good that rust-analyzer doesn't belly-up on a panic in some random
assist.

It is less good that rust-analyzer devs only know that the assists are
buggy when they are actively looking at the logs.
@bors
Copy link
Contributor

bors bot commented Aug 22, 2021

Canceled.

@matklad
Copy link
Member Author

matklad commented Aug 22, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 22, 2021

@bors bors bot merged commit 0960d4e into rust-lang:master Aug 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants