Skip to content

Update default rust target to 1.33. #1530

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2019
Merged

Update default rust target to 1.33. #1530

merged 3 commits into from
Mar 4, 2019

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 4, 2019

Closes #1529.

@highfive
Copy link

highfive commented Mar 4, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio emilio mentioned this pull request Mar 4, 2019
Closed
emilio added 3 commits March 4, 2019 03:53
@emilio
Update default rust target to 1.33.
ed6e1bb 
Closes rust-lang#1529.
@emilio
codegen: Properly track alignment of unions.
9134679 
This makes us not unnecessarily add repr(align) to unions.

Closes rust-lang#1498.
@emilio
integration: Fix integration tests with rust 1.33.
a43cc2a 
Alignment arrays are not needed anymore, since we have repr(align).
@emilio emilio merged commit 3a6864c into rust-lang:master Mar 4, 2019
@emilio emilio deleted the rustup branch March 4, 2019 02:55
@emilio emilio mentioned this pull request Mar 13, 2019
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilio @highfive