Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move CLI options to bindgen #2983

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Move CLI options to bindgen #2983

merged 2 commits into from
Nov 20, 2024

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Nov 20, 2024

This is done in an effort to allow bindgen (the library) parse arguments from a configuration file just like #2917 does for bindgen-cli.

@pvdrz pvdrz force-pushed the pvdrz/move-cli-options branch from 14cc944 to 1a26a20 Compare November 20, 2024 01:27
@pvdrz pvdrz added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 1d8de67 Nov 20, 2024
28 checks passed
@kulp
Copy link
Member

kulp commented Nov 20, 2024

@pvdrz Does this essentially reverse the motivation of #2284 ("This means that bindgen no longer depends on clap"), which came from #2238 and #2238 (comment) in particular?

Other possibly-relevant issues and PRs: #1970, #1581, #1111, #2381.

I have not thought deeply about this and I am unlikely to grow a strong opinion on it, but if this represents a policy reversal then it may be helpful to document the effects for the next release.

@pvdrz
Copy link
Contributor Author

pvdrz commented Nov 20, 2024

no, the bindgen crate will only depend on clap if the __cli feature is enabled and this feature is not intended for public use.

@kulp
Copy link
Member

kulp commented Nov 20, 2024

no, the bindgen crate will only depend on clap if the __cli feature is enabled and this feature is not intended for public use.

Thanks, I had missed that.

@pvdrz
Copy link
Contributor Author

pvdrz commented Nov 20, 2024

yeah I checked annd cargo tree -p bindgen doesn't show clap but cargo tree -p bindgen-cli does

@pvdrz pvdrz deleted the pvdrz/move-cli-options branch December 9, 2024 04:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants