use statements anywhere but top of module

[llogiq]

In an earlier version of sokoban-rs, the author included a use statement in the middle of a loop.

Let's catch such stuff and propose putting it at the top of the file.

[Manishearth]

Meh, this is actually a pattern I've seen used often and it's okay IMO (esp. for test imports).

Allow fine though

[birkenfeld]

I feel that at least function-local should be allowed if at the top of the function.

[llogiq]

(esp. for test imports).

We probably should ignore use statements within #cfg(test) (or perhaps any #cfg).

I'm fine with Allow.

And again, we can have multiple lints ranging from pedantic to lenient.

[birkenfeld]

Turns out use isn't even allowed in blocks if not at the start...

[llogiq]

Yeah, but there can be a lot of blocks within a function...

[sanmai-NL]

@llogiq: what is the undesirable effect of a use inside e.g. a loop block?

Is it possible to elaborate a bit why this is bad? Doing it could enhance self-containedness of functions. Not to say I don't empathize with your apprehension ...

[BenjaminBrienen]

We'll focus on "module-level use statements should not come after other items"

[utkrsharmaa]

Hey, I wanted to work on this as a first issue, if this is still wanted and no one else is working on it; I'd be glad to. Please let me know the current status of this issue.

[samueltardieu]

Sure, feel free to claim the issue (see the CONTRIBUTING.md file) if you want to work on it!

[utkrsharmaa]

@rustbot claim