Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

shadow lint should use visitor or ExprUseVisitor #318

Closed
Manishearth opened this issue Sep 8, 2015 · 2 comments · Fixed by #7338
Closed

shadow lint should use visitor or ExprUseVisitor #318

Manishearth opened this issue Sep 8, 2015 · 2 comments · Fixed by #7338
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages E-medium Call for participation: Medium difficulty level problem and requires some initial experience.

Comments

@Manishearth
Copy link
Member

We're duplicating a lot of the work Visitor does.

ExprUseVisitor might work, but there's no way of handling scopes.

cc @birkenfeld thoughts?
@Manishearth Manishearth mentioned this issue Sep 8, 2015
Closed
@llogiq
Copy link
Contributor

llogiq commented Sep 8, 2015

The ExprUseVisitor could at least work for the contains-check (though maybe it's even overkill for that).

@llogiq
Copy link
Contributor

llogiq commented Nov 10, 2015

#449 at least uses the Visitor for the contains check.

@oli-obk oli-obk added E-medium Call for participation: Medium difficulty level problem and requires some initial experience. C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels May 10, 2017
@camsteffen camsteffen mentioned this issue Jun 9, 2021
Merged
bors added a commit that referenced this issue Sep 30, 2021
@bors
Auto merge of #7338 - camsteffen:shadow, r=llogic
75167bb 
Re-write shadow lints

changelog: Move shadow_unrelated to restriction
changelog: The shadow lints find a lot more shadows and are not limited to certain patterns

Drastically simplifies the implementation. Catches a lot more cases.

I removed the "initialization happens here" note. It is not helpful IMO.

Closes #318
Fixes #2890
Fixes #6563
Fixes #7588
Fixes #7620
@bors bors closed this as completed in f8303ad Sep 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages E-medium Call for participation: Medium difficulty level problem and requires some initial experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-write shadow lints camsteffen/rust-clippy
3 participants
@oli-obk @Manishearth @llogiq