Skip to content

needless_lifetimes: lint local macros #10257

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 30, 2023

fixes #5283

changelog: [needless_lifetimes]: lint local macros

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 30, 2023
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
@tylerjw tylerjw changed the title needless_lifetimes: macro test needless_lifetimes: lint local macros Jan 30, 2023
@tylerjw
Copy link
Contributor Author

tylerjw commented Jan 30, 2023

r? @xFrednet

Here is another one. I used my new knowledge of test using code from an external crate here.

@rustbot rustbot assigned xFrednet and unassigned flip1995 Jan 30, 2023
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 31, 2023

📌 Commit 4fde96c has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 31, 2023

⌛ Testing commit 4fde96c with merge e1224cd...

@bors
Copy link
Contributor

bors commented Jan 31, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e1224cd to master...

@bors bors merged commit e1224cd into rust-lang:master Jan 31, 2023
@tylerjw tylerjw deleted the issue_5283 branch February 1, 2023 15:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip needless_lifetimes inside macros (needs test!)
5 participants