Do not suggest to derive Default on generics with implicit arguments
#10399
Conversation
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
samueltardieu
changed the title
Default on generics with implicit arguments
| } | ||
| if let Some(PathSegment { args, .. }) = p.segments.last() { | ||
| let args = args.map(|a| a.args).unwrap_or(&[]); | ||
| if substs.len() != args.len() || args.iter().any(|arg| !matches!(arg, GenericArg::Lifetime(_))) { |
There was a problem hiding this comment.
nit: comment explaining what this is checking (and why checking against substs solves the problem)
There was a problem hiding this comment.
Sure, will do while rebasing.
There was a problem hiding this comment.
This hasn't addressed my parenthetical:
Please make it clear why substs.len() != args.len() is sufficient to check that if there are defaults involved, so someone reading this code without a clear idea of substs can still understand
There was a problem hiding this comment.
Hopefully this is better now.
|
☔ The latest upstream changes (presumably #10401) made this pull request unmergeable. Please resolve the merge conflicts. |
samueltardieu
force-pushed
the
issue-10396
branch
from
825bd23 to
50b5f33
Compare
Done. |
samueltardieu
force-pushed
the
issue-10396
branch
2 times, most recently
from
8a08279 to
f7042b5
Compare
samueltardieu
force-pushed
the
issue-10396
branch
from
f7042b5 to
c82ff00
Compare
|
(noticed a typo in the explanation and fixed it) |
|
@bors r+ thanks for working on this! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #10396
changelog: FP: [
derivable_impls]: do not suggest to deriveDefaulton generics with implicit arguments