Skip to content

Don't lint manual_clamp in const contexts. #10479

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Mar 10, 2023

fixes #10474

Probably worth including in the sync.
r? @flip1995

changelog: [manual_clamp]: Don't lint in const contexts.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 10, 2023
@flip1995
Copy link
Member

@bors r+

Thanks!

This is a nice fix, but I already did the sync rust-lang/rust#108974

Since the release was yesterday, this is not really time critical IMO. So I will just include it in the next sync.

@bors
Copy link
Contributor

bors commented Mar 10, 2023

📌 Commit 797d8bf has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 10, 2023

⌛ Testing commit 797d8bf with merge 8e1dd06...

@Jarcho
Copy link
Contributor Author

Jarcho commented Mar 10, 2023

I noticed the lint was in the nursery after making this.

@bors
Copy link
Contributor

bors commented Mar 10, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8e1dd06 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 10, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8e1dd06 to master...

@bors bors merged commit 8e1dd06 into rust-lang:master Mar 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_clamp suggests using clamp() in a const function
4 participants