-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix diverging_sub_expression
not checking body of block
#10785
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #10802) made this pull request unmergeable. Please resolve the merge conflicts. |
Clippy has a no merge commit policy. You'll have to rebase your changes instead. |
5882252
to
0894a9d
Compare
Could've sworn I did that the first time, not sure what I did. I guess it's clear now I have no idea what I'm doing 😄 |
Feel free to squash after fixing the last little nit. |
Update mixed_read_write_in_expression.rs Update diverging_sub_expression.stderr
8ee9598
to
c1c134a
Compare
Thank you. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #10776
This also adds a warning to the test
ui/never_loop.rs
, not sure if this is correct or not.changelog: [
diverging_sub_expression
]: Fix false negatives with body of block