Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New lint [bare_dos_device_names] #11062

Closed
wants to merge 3 commits into from

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jul 2, 2023

Closes #8511

I've made this a draft as it's not quite ready yet. But whoever's randomly picked, feel free to review ^^ Everything I've left out so far and/or haven't finished is really because I didn't get enough sleep :D I've left some TODOs about the place and will likely make it a tad more general soon enough.

changelog: New lint [bare_dos_device_names]

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 2, 2023
@Centri3 Centri3 marked this pull request as ready for review July 3, 2023 17:59
@Centri3 Centri3 force-pushed the bare_dos_device_names branch from 123ffdf to f0e740f Compare July 3, 2023 18:02
@bors
Copy link
Contributor

bors commented Jul 8, 2023

☔ The latest upstream changes (presumably #10788) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the bare_dos_device_names branch 4 times, most recently from 9045dcb to ecabf1e Compare July 14, 2023 05:23
@bors
Copy link
Contributor

bors commented Jul 18, 2023

☔ The latest upstream changes (presumably #11140) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the bare_dos_device_names branch 2 times, most recently from 9ea640d to d7a580e Compare July 19, 2023 09:33
@bors
Copy link
Contributor

bors commented Jul 20, 2023

☔ The latest upstream changes (presumably #11107) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the bare_dos_device_names branch from d7a580e to 9e8e96b Compare July 20, 2023 10:16
@bors
Copy link
Contributor

bors commented Jul 21, 2023

☔ The latest upstream changes (presumably #11003) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D

Thank you to @Centri3 and the reviewers for the time, that you already put into this!

@rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review

@xFrednet xFrednet closed this Mar 31, 2024
@rustbot rustbot added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2024
@Centri3 Centri3 deleted the bare_dos_device_names branch April 1, 2024 16:58
@Centri3
Copy link
Member Author

Centri3 commented Apr 1, 2024

Triaging my old PRs in case someone wants to pick them up, I don't really think the implementation needs any more work, but there is a TODO left as a question - Should we lint these specific device names?

Regardless I think I'll get around to this too at some point if nobody else does

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-inactive-closed Status: Closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on use of Windows DOS devices in paths
5 participants