-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rename incorrect_impls to non_canonical_impls, move them to warn by default #11358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
Both of the lints are checking the function body for the most obvious implementation so the name and lint category are both justified. |
001b6ee
to
4f40fc4
Compare
(added a note mentioning that it's a requirement for Not being the most obvious implementation doesn't make them incorrect, the before example in |
4f40fc4
to
78dceaf
Compare
The lint on
|
☔ The latest upstream changes (presumably #11249) made this pull request unmergeable. Please resolve the merge conflicts. |
78dceaf
to
6150bf5
Compare
Whoops, apparently if you forget to commit your changes and push a commit equal to the target branch it'll close the PR for you |
Yay, more perplexing behaviour from github! @bors r+ |
Rename incorrect_impls to non_canonical_impls, move them to warn by default The wording/category of these feel too strong to me, I would expect most of the time it's linting the implementations aren't going to be *incorrect*, just unnecessary changelog: rename `incorrect_clone_impl_on_copy_type` to [`non_canonical_clone_impl`] changelog: rename `incorrect_partial_ord_impl_on_ord_type` to [`non_canonical_partial_ord_impl`] changelog: Move [`non_canonical_clone_impl`], [`non_canonical_partial_ord_impl`] to suspicious
💔 Test failed - checks-action_test |
Looks like you need to re-bless the tests. Should also change the error message which still mentions that it's an incorrect impl. |
71e716a
to
1aab4ca
Compare
That's odd.. I don't see that change locally |
1aab4ca
to
b99921a
Compare
I do after rebasing 🤷 |
One more time. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
It looks like this missed the 1.73.0 release? |
Yeah, it's still |
The wording/category of these feel too strong to me, I would expect most of the time it's linting the implementations aren't going to be incorrect, just unnecessary
changelog: rename
incorrect_clone_impl_on_copy_type
to [non_canonical_clone_impl
]changelog: rename
incorrect_partial_ord_impl_on_ord_type
to [non_canonical_partial_ord_impl
]changelog: Move [
non_canonical_clone_impl
], [non_canonical_partial_ord_impl
] to suspicious