single_match: fix checking of explicitly matched enums
#11441
Conversation
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
issue_11365
branch
2 times, most recently
from
ce1b80f to
f475b85
Compare
|
☔ The latest upstream changes (presumably #11563) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? clippy |
|
☔ The latest upstream changes (presumably #12198) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I won't be back until Wednesday. If anyone have the capacity, feel free to review this :) r? clippy |
|
I've been postponing it for some time, I'll take a deep look at this tomorrow (compromise), if then it doesn't click, I'll do a reroll |
Jarcho
force-pushed
the
issue_11365
branch
3 times, most recently
from
c2e9608 to
ca1236d
Compare
|
Hey, this is triage: It looks like @blyxyas is currently busy, let's pick a new reviewer. r? clippy |
|
r? clippy (in mumbai for two weeks, not using the computer as much) |
|
☔ The latest upstream changes (presumably #13115) made this pull request unmergeable. Please resolve the merge conflicts. |
|
LGTM, thanks! Roses are red, |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #11365
This approach has false-negatives, but fixing them will require a significant amount of additional state tracking. The comment in
add_and_patshas the explanation.changelog:
single_match: correct checking if the match explicitly matches all of an enum's variants.