Skip to content

Fix dbg_macro semi span calculation #11743

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Alexendoo
Copy link
Member

span_including_semi was using a BytePos to index into a file's source which happened to work because the root file of the test started at BytePos 0, it didn't work for other files

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 1, 2023
@xFrednet
Copy link
Member

xFrednet commented Nov 2, 2023

LGTM, thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2023

📌 Commit 57a4644 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 2, 2023

⌛ Testing commit 57a4644 with merge 902c79c...

@bors
Copy link
Contributor

bors commented Nov 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 902c79c to master...

@bors bors merged commit 902c79c into rust-lang:master Nov 2, 2023
@Alexendoo Alexendoo deleted the dbg-macro-stmt-span branch November 2, 2023 21:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants