Skip to content

Return Some from walk_to_expr_usage more #11812

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 15, 2023

fixes #11786
supersedes #11097

The code removed in the first commit would have needed changes due to the second commit. Since it's useless it just gets removed instead.

changelog: needless_borrow: Fix linting in tuple and array expressions.

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 15, 2023
@Alexendoo
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2024

📌 Commit cdc4c69 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 6, 2024

⌛ Testing commit cdc4c69 with merge b1e5a58...

@bors
Copy link
Contributor

bors commented Feb 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing b1e5a58 to master...

@bors bors merged commit b1e5a58 into rust-lang:master Feb 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_borrow stopped triggering on references to Option<&_> if they're returned as part of a tuple
4 participants