Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

declare_interior_mutable_const: Ignore pointer types. #13290

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Aug 20, 2024

fixes #12951
fixes #13233

changelog: declare_interior_mutable_const: Ignore pointer types.

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2024
@Jarcho
Copy link
Contributor Author

Jarcho commented Aug 20, 2024

r? @Alexendoo

@rustbot rustbot assigned Alexendoo and unassigned Centri3 Aug 20, 2024
@Jarcho Jarcho force-pushed the interior_mut_quick branch from bb972aa to 687d4e3 Compare August 20, 2024 16:01
@Jarcho Jarcho added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 20, 2024
@Alexendoo
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2024

📌 Commit 687d4e3 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 20, 2024

⌛ Testing commit 687d4e3 with merge e5a1ef0...

@bors
Copy link
Contributor

bors commented Aug 20, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing e5a1ef0 to master...

@bors bors merged commit e5a1ef0 into rust-lang:master Aug 20, 2024
8 checks passed
@Jarcho Jarcho added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2024
[beta] Clippy backports

r? `@Mark-Simulacrum`

Backports:
- rust-lang/rust-clippy#12892
- rust-lang/rust-clippy#13168
- rust-lang/rust-clippy#13290

Both 12892 and 13290 are fixes for stable regressions. The first is a little large, but mostly just reverts the change that caused the regression. 13168 is to handle the `Error` trait moving to core in 1.81.
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
6 participants