Skip to content

Cleanup const_float_classify #13510

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

Cleanup const_float_classify #13510

merged 1 commit into from
Oct 13, 2024

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Oct 6, 2024 •
edited
Loading

As mentioned at #13508 const_float_classify has been stabilized recently in rust-lang/rust#130157 and can be cleanup

Close #13508

changelog: [none]

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2024
@alex-semenyuk alex-semenyuk changed the title Clean up const_float_classify Cleanup const_float_classify Oct 6, 2024
y21
y21 reviewed Oct 6, 2024
View reviewed changes
@alex-semenyuk alex-semenyuk force-pushed the cleanup_const_float_classify branch from 55688a8 to 55d1e88 Compare October 9, 2024 21:01
@alex-semenyuk alex-semenyuk marked this pull request as draft October 9, 2024 21:01
@alex-semenyuk alex-semenyuk force-pushed the cleanup_const_float_classify branch 2 times, most recently from 55d1e88 to 3f68c41 Compare October 10, 2024 08:23
@alex-semenyuk alex-semenyuk force-pushed the cleanup_const_float_classify branch from a100fd2 to cb19f23 Compare October 10, 2024 17:09
@alex-semenyuk alex-semenyuk marked this pull request as ready for review October 10, 2024 17:21
@alex-semenyuk alex-semenyuk requested a review from y21 October 10, 2024 17:22
@llogiq
Copy link
Contributor

llogiq commented Oct 13, 2024

Looks good to me. Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2024

📌 Commit cb19f23 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 13, 2024

⌛ Testing commit cb19f23 with merge 04849bd...

@bors
Copy link
Contributor

bors commented Oct 13, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 04849bd to master...

@bors bors merged commit 04849bd into rust-lang:master Oct 13, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@y21 y21

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up const_float_classify leftovers
5 participants
@alex-semenyuk @rustbot @llogiq @bors @y21