Skip to content

borrow_deref_ref: do not trigger on &raw references #13600

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

samueltardieu
Copy link
Contributor

changelog: [borrow_deref_ref]: do not trigger on &raw references

Fix #13584

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 24, 2024
@xFrednet
Copy link
Member

&raw seems to be a feature that will be stabilized¹. This fix should probably be backported.

@rustbot label +beta-nominated

¹: rust-lang/rust#127679


The fix looks good to me, thank you!


Roses are red,
Violets are blue,
A &raw reference,
no longer warn

@bors
Copy link
Contributor

bors commented Oct 27, 2024

📌 Commit b0412d0 has been approved by xFrednet

It is now in the queue for this repository.

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2024
@bors
Copy link
Contributor

bors commented Oct 27, 2024

⌛ Testing commit b0412d0 with merge c02f3a2...

@bors
Copy link
Contributor

bors commented Oct 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing c02f3a2 to master...

@bors bors merged commit c02f3a2 into rust-lang:master Oct 27, 2024
8 checks passed
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 21, 2024
@flip1995
Copy link
Member

rust-lang/rust#133299

@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
…k-Simulacrum

[beta] Clippy backports

r? `@Mark-Simulacrum`

Backports:
- rust-lang/rust-clippy#13553
- rust-lang/rust-clippy#13600

The first is just a regrouping to a allow-by-default group, as we figured that the lint would be too noisy as a warn-by-default lint. That lint was added last release cycle, so we want to do the re-grouping before it hits stable.

The second is a bug fix for `&raw` references that are already stable in `1.82`, but we don't want to wait another release cycle for the fix to land on stable.

Both commits are already synced to the current `master branch`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2024
…k-Simulacrum

[beta] Clippy backports

r? `@Mark-Simulacrum`

Backports:
- rust-lang/rust-clippy#13553
- rust-lang/rust-clippy#13600

The first is just a regrouping to a allow-by-default group, as we figured that the lint would be too noisy as a warn-by-default lint. That lint was added last release cycle, so we want to do the re-grouping before it hits stable.

The second is a bug fix for `&raw` references that are already stable in `1.82`, but we don't want to wait another release cycle for the fix to land on stable.

Both commits are already synced to the current `master branch`.
@samueltardieu samueltardieu deleted the push-tzuvnutssmrs branch January 22, 2025 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

borrow_deref_ref does not understand &raw
5 participants