Skip to content

Fix from_over_into lint suggesting invalid code #14409

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2025
Merged

Fix from_over_into lint suggesting invalid code #14409

merged 3 commits into from
Mar 15, 2025

Conversation

KonaeAkira
Copy link
Contributor

fixes #112502

changelog: [from_over_into]: fix invalid code suggestion when self parameter has type annotation

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 14, 2025
Alexendoo
Alexendoo approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Alexendoo Alexendoo added this pull request to the merge queue Mar 15, 2025
Merged via the queue into rust-lang:master with commit 5c031d1 Mar 15, 2025
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo clippy failed to apply fixes
4 participants
@KonaeAkira @rustbot @Alexendoo @Jarcho