fix: map_entry: don't emit lint before checks have been performed #14568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Apr 9, 2025
meithecatte
force-pushed
the
fix-map-entry
branch
from
1f359bf to
189b076
Compare
samueltardieu
added
the
beta-nominated
|
@Alexendoo I've beta-nominated it, it would be best for the bug not to reach stable. |
flip1995
added
beta-accepted
flip1995
removed
the
beta-accepted
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14449, introduced in #14314
changelog: [
map_entry]: fix a false positive where the lint would trigger without any insert calls present