Skip to content

Conversation

SLUCHABLUB
Copy link
Contributor

When trying to cast a usize or isize using as to a type of potentially smaller size the cast_precision_loss would claim that the size of usize is "32 or 64 bits". It is now corrected to "16, 32, or 64 bits".

changelog: [cast_precision_loss]: fix the error messages claim regarding the size of usize and isize.

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 4, 2025
@samueltardieu
Copy link
Member

Shouldn't we give a better error message? (and use "may cause" since on 16 bit usize platforms this is fine)

For example:

casting `usize` to `f32` may cause a loss of precision (`usize` can be as large as 64 bits wide depending of the target architecture, but `f32`'s mantissa is only 23 bits wide)

@SLUCHABLUB
Copy link
Contributor Author

Yes, something like that would be even better. I will look over it.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants