redundant_clone: split iterator checks into redundant_iter_cloned
#15277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
No changes for 81e8c67 |
rustbot
added
S-blocked
Jarcho
removed
A-lint
|
The feature freeze not can be ignored. This is just splitting an existing lint. |
blyxyas
requested changes
Jul 15, 2025
| @@ -96,7 +95,7 @@ pub(super) fn check<'tcx>( | |||
| } | |||
|
|
|||
| let (lint, msg, trailing_clone) = match op { | |||
| Op::RmCloned | Op::NeedlessMove(_) => (REDUNDANT_CLONE, "unneeded cloning of iterator items", ""), | |||
There was a problem hiding this comment.
Hmmmm we may need to perform some tomfoolery here, checking for which lint is active, and if only redundant_clone is, still lint it with a deprecation notice for a couple versions (If redundant_iter_cloned is active, we can directly report that and avoid redundant_clone altogether)
There was a problem hiding this comment.
redundant_clone is in the nursery right now since it's main part is very broken so I don't think we need to do anything special.
rustbot
added
the
S-waiting-on-author
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to split the lints crate.
changelog: split
redundant_cloneiterator checks intoredundant_iter_clonedSummary Notes
Managed by
@rustbot—see help for details