Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to latest nightly #1715

Merged
merged 4 commits into from
May 3, 2017
Merged

Update to latest nightly #1715

merged 4 commits into from
May 3, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 2, 2017

fixes #1714

needs to wait for the next nightly

@ishitatsuyuki
Copy link
Contributor

I'm quite sure that today's nightly is ready, please merge.

@oli-obk oli-obk closed this May 3, 2017
@oli-obk oli-obk reopened this May 3, 2017
@ishitatsuyuki
Copy link
Contributor

New failure:

error[E0106]: missing lifetime specifier
   --> clippy_lints/src/loops.rs:875:35
    |
875 |     indexed: HashMap<Name, Option<CodeExtent>>, // indexed variables, the extent is None for global
    |                                   ^^^^^^^^^^ expected lifetime parameter

@oli-obk
Copy link
Contributor Author

oli-obk commented May 3, 2017

Already on it :) mostly caused by rust-lang/rust#41662

@oli-obk
Copy link
Contributor Author

oli-obk commented May 3, 2017

My suggestion changes made some of our suggestions ugly. I fixed some, but there are others left. I plan to improve this by both changes in rustc and in clippy.

@ishitatsuyuki
Copy link
Contributor

Build looks good. Looking forward to be merged.

@ishitatsuyuki
Copy link
Contributor

By the way, here's a recommendation: do the work on master branch, tag it once nightly is released.

@ishitatsuyuki
Copy link
Contributor

The cache seems to be ****ed up. Maybe something done wrong in CI configuration?

@oli-obk oli-obk merged commit ef7ff03 into master May 3, 2017
@oli-obk oli-obk deleted the rustup branch May 3, 2017 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation breakage: rustc_errors::CodeSuggestion
2 participants