Don't lint range syntax with var name start and/or end
#2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Mar 5, 2018
| @@ -36,10 +38,14 @@ impl LintPass for RedundantFieldNames { | |||
|
|
|||
| impl<'a, 'tcx> LateLintPass<'a, 'tcx> for RedundantFieldNames { | |||
| fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { | |||
| if let ExprStruct(_, ref fields, _) = expr.node { | |||
| if let ExprStruct(ref path, ref fields, _) = expr.node { | |||
There was a problem hiding this comment.
Have you tried checking with the in_macro method? I think this should have expansion info, so we should be able to detect it that way
There was a problem hiding this comment.
I didn't know in_macro() until now.
But the method intends not to treat range expressions as "in_macro" (since #1373).
So I've added a method which determines whether an expression is a range expression.
https://github.com/rust-lang-nursery/rust-clippy/pull/2507/files#diff-5b47b8bbc8833f6268e936ea8682644dR68
Now range expressions are ignored, and hand-written Range family structs are treated normally by the lint.
There was a problem hiding this comment.
nice! The diff lgtm. Let's wait for travis and then merge
Hand-written `Range` struct family are treated normally.
ghost
mentioned this pull request
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2491.
But this PR introduces new false-negative:
does not lint hand-written
Rangestruct family with var namestartand/orend,i.e.
std::ops::Range { start: start, end: end }But I guess it's rare to write them explicitly.