The Great Generics Generalisation: Clippy edition #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the errors produced by (re)moving, merging or renaming structs, fields and methods by rust-lang/rust#48149 and rust-lang/rust#51580
Addresses the move/zip of Lifetimes and Types vectors from hir::PathParameters into the args vector of GenericArgs
eddyb
reviewed
Jun 27, 2018
| false | ||
| } else { | ||
| // FIXME(flip1995): messy, improve if there is a better option | ||
| // in the compiler |
There was a problem hiding this comment.
This is usually done with an iterator and matching on (it.next(), it.next()).
eddyb
reviewed
Jun 27, 2018
| _ => None, | ||
| }).collect(); | ||
| if types.len() == 1 { | ||
| ty_snippet = snippet_opt(cx, types[0].span); |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2869
Resolves The conflicts produced by rust-lang/rust#48149, rust-lang/rust#51580 and rust-lang/rust#51726
r? @oli-obk