RIIR update_lints: Replace lint count in README.md #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because now `usable_lints` will also exclude internal lints.
phansch
force-pushed
the
riir_update_lints_first_replace_region
branch
from
a7fcf89 to
0318fdd
Compare
This allows the usage of `util/dev update_lints` which will write the new lint_count to the `README.md`.
phansch
force-pushed
the
riir_update_lints_first_replace_region
branch
from
0318fdd to
956987f
Compare
phansch
added
the
S-waiting-on-author
oli-obk
reviewed
Oct 16, 2018
clippy_dev/src/lib.rs
Outdated
| f.write_all(replaced.as_bytes()).expect("Unable to write file"); | ||
| // Ensure we write the changes with a trailing newline so that | ||
| // the file has the proper line endings. | ||
| f.write(b"\n").expect("Unable to write file"); |
There was a problem hiding this comment.
dogfood is unhappy here and in a few (less relevant) places.
|
⭐ ⭐ ⭐ ⭐ ⭐ documentation would approve again |
`expect_fun_call` causes a false-positive, so I disabled it for now.
oli-obk
approved these changes
Oct 16, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the usage of
util/dev update_lintswhich will write the currentlint count to the
README.md.This also adds two new methods:
replace_region_in_fileandreplace_region_in_textwhich handle all the meaty stuff of replacing regions of text. For now these are only used to update the lint count inREADME.mdcc #2882