RIIR update_lints: Update changelog links #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now also updates the link list at the bottom of the changelog.
phansch
commented
Oct 17, 2018
| @@ -59,8 +59,8 @@ fn print_lints() { | |||
| } | |||
|
|
|||
| fn update_lints() { | |||
| let lint_list = gather_all(); | |||
| let usable_lints: Vec<Lint> = Lint::usable_lints(lint_list).collect(); | |||
| let lint_list: Vec<Lint> = gather_all().collect(); | |||
There was a problem hiding this comment.
This is now a Vec because the iterator would have been consumed the first time it's used. Now it's cloning the Vec for every replace_region_in_file. Not sure if there's a better way. At least the files are only parsed once.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now also updates the link list at the bottom of the changelog.
cc #2882