Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README local run command to remove syspath #3593

Merged
merged 1 commit into from Dec 30, 2018
Merged

Update README local run command to remove syspath #3593

merged 1 commit into from Dec 30, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2018

Since #3257 was reverted, including the sysroot in RUSTFLAGS gives the
error Option 'sysroot' given more than once

Since #3257 was reverted, including the sysroot in RUSTFLAGS gives the
error `Option 'sysroot' given more than once`
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 30, 2018
@phansch
Copy link
Member

phansch commented Dec 30, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2018

📌 Commit f4cf82c has been approved by phansch

@phansch
Copy link
Member

phansch commented Dec 30, 2018

also cc #3594

@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit f4cf82c with merge 61bfb39...

bors added a commit that referenced this pull request Dec 30, 2018
Update README local run command to remove syspath

Since #3257 was reverted, including the sysroot in RUSTFLAGS gives the
error `Option 'sysroot' given more than once`
@o01eg
Copy link
Contributor

o01eg commented Dec 30, 2018

It should works after #3594 because rustc --print sysroot was left intact.

@bors
Copy link
Contributor

bors commented Dec 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing 61bfb39 to master...

@bors bors merged commit f4cf82c into rust-lang:master Dec 30, 2018
@ghost ghost deleted the readme-syspath-2 branch January 6, 2019 08:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants