Skip to content

HirIdify some lints #3814

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2019
Merged

HirIdify some lints #3814

merged 3 commits into from
Feb 26, 2019

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Feb 24, 2019

Unblocks rust-lang/rust#58561 (a part of rust-lang/rust#57578). Can we branch it like with #3790? I can rebase on a different commit if need be.

Haven't had time to run tests yet, so I'd wait for Travis 🙈.

@ljedrz ljedrz mentioned this pull request Feb 24, 2019
Merged
8 tasks
@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 24, 2019

Ah, I forgot this will already break on new rustc stuff; in any case, please advise which commit I should attach this PR to (unless this one's fine).

@flip1995
Copy link
Member

flip1995 commented Feb 24, 2019 •
edited
Loading

Can we branch it like with #3790?

Done!

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 25, 2019 •
edited
Loading

There was a bug; I went through all the changes and found it (mixed the ids in one spot), but unfortunately I'm unable to run tests at this moment 😐; hope it's the only one.

Can we please branch the new commit so I can retry with rust-lang's CI?

@oli-obk
Copy link
Contributor

oli-obk commented Feb 25, 2019

done

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 25, 2019

Yep, that was the only one; thanks!

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 26, 2019

rust-lang/rust#58561 was merged, feel free to merge this branch now.

@phansch
Copy link
Member

phansch commented Feb 26, 2019

You're fast! Retriggering CI =)

@phansch phansch closed this Feb 26, 2019
@phansch phansch reopened this Feb 26, 2019
@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 26, 2019

I'm guessing the branch build doesn't have the most recent rust-lang commits?

@phansch
Copy link
Member

phansch commented Feb 26, 2019

I'm guessing the branch build doesn't have the most recent rust-lang commits?

Nope, just some formatting to be done: https://travis-ci.com/rust-lang/rust-clippy/jobs/180536937#L1395

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 26, 2019

Ah, I was looking at appveyor that was showing old errors; I'll send a fix shortly.

@phansch
Copy link
Member

phansch commented Feb 26, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Feb 26, 2019

📌 Commit c1b65ec has been approved by phansch

@bors
Copy link
Contributor

bors commented Feb 26, 2019

⌛ Testing commit c1b65ec with merge 412d41a...

bors added a commit that referenced this pull request Feb 26, 2019
@bors
Auto merge of #3814 - ljedrz:HirIdification_lockstep_upgrade, r=phansch
412d41a 
HirIdify some lints

Unblocks rust-lang/rust#58561 (a part of [rust-lang/rust#57578](rust-lang/rust#57578)). Can we branch it like with #3790? I can rebase on a different commit if need be.

Haven't had time to run tests yet, so I'd wait for Travis 🙈.
@bors
Copy link
Contributor

bors commented Feb 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 412d41a to master...

@bors bors merged commit c1b65ec into rust-lang:master Feb 26, 2019
@ljedrz ljedrz deleted the HirIdification_lockstep_upgrade branch February 26, 2019 11:13
@bors bors mentioned this pull request Feb 26, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljedrz @flip1995 @oli-obk @phansch @bors