Rustup #3945
Merged
Rustup #3945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 3fe5eea has been approved by |
bors
added a commit
that referenced
this pull request
Apr 12, 2019
Rustup cc rust-lang/rust#59227 (comment) This fix is obsolet once rust-lang/rust#59779 and #3926 is merged.
|
☀️ Test successful - checks-travis, status-appveyor |
|
If you're going to create submodule update PR, please also update the RLS submodule to the newest master! (Fixes formatting, if not, I'll be be submitting a PR myself) |
|
Miri could be updated as well. |
Should we wait for rust-lang/rls#1424 to be merged before creating a submodule update? |
|
@flip1995 Rust patches dependencies to use Clippy from submodule so it doesn't matter. |
|
It doesn't, but please include rust-lang/rls@40778f5 as well as part of the submodule update |
|
Done: rust-lang/rust#59916 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#59227 (comment)
This fix is obsolet once rust-lang/rust#59779 and #3926 is merged.