Skip to content

Fix GHA after the merge #5162

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix GHA after the merge #5162

merged 1 commit into from
Feb 12, 2020

Conversation

flip1995
Copy link
Member

changelog: none

@flip1995
Use list instead of array for branch names
b0d25de 
This is the officially supported method
@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2020

📌 Commit b0d25de has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 12, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@flip1995
Copy link
Member Author

@bors p=1000

@bors
Copy link
Contributor

bors commented Feb 12, 2020

⌛ Testing commit b0d25de with merge db7b36e...

bors added a commit that referenced this pull request Feb 12, 2020
@bors
Auto merge of #5162 - flip1995:gha_fix, r=flip1995
db7b36e 
Use list instead of array for branch names

changelog: none
@flip1995 flip1995 changed the title Use list instead of array for branch names Fix GHA after the merge Feb 12, 2020
@flip1995
Copy link
Member Author

@bors r- retry

@flip1995
Copy link
Member Author

@bors treeclosed- try

@bors
Copy link
Contributor

bors commented Feb 12, 2020

⌛ Trying commit b900aaf with merge 5c883ee...

bors added a commit that referenced this pull request Feb 12, 2020
@bors
Auto merge of #5162 - flip1995:gha_fix, r=<try>
5c883ee 
Fix GHA after the merge

changelog: none
@bors

This comment has been minimized.

# to view
@flip1995
Copy link
Member Author

The reason for the failure in the integration tests was, that a PR in the rustc repo got merged between the integration_build step and the integration test step. This is just unlucky and cannot be fixed by changing anything in the workflow. But it happened or the first time in I don't know how many try runs (20? 50? ..?). Splitting the build up from the tests gives a speedup of ~7min, so I think we can live with that happening now or then.

Let's see how often this happens in practice.

@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2020

📌 Commit b0d25de has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 12, 2020

⌛ Testing commit b0d25de with merge 2432a16...

bors added a commit that referenced this pull request Feb 12, 2020
@bors
Auto merge of #5162 - flip1995:gha_fix, r=flip1995
2432a16 
Fix GHA after the merge

changelog: none
@bors
Copy link
Contributor

bors commented Feb 12, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 2432a16 to master...

@bors bors merged commit b0d25de into rust-lang:master Feb 12, 2020
@flip1995 flip1995 deleted the gha_fix branch February 12, 2020 11:05
@flip1995 flip1995 mentioned this pull request Feb 18, 2020
Merged
bors added a commit that referenced this pull request Feb 19, 2020
@bors
Auto merge of #5190 - flip1995:nuke_traveyor, r=phansch,Manishearth,l…
06f0ab0 
…logiq,flip1995

I like to move it, move it

GHA now runs in the background for 6 days (#5088)

Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle))

Some PRs were:
- #5163
- #5170
- #5168
- #5173
- #5171
- #5156
- #4809
- #5177
- #5182
- #5183
- #5184
- #5185
- #5186
- #5181
- #5189

Bug with GHA:
- When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in #5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes
- Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet)

## Before merging this, rust-lang/rust-central-station#578 has to get merged

This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move.

changelog: Clippy completely runs on GHA now 🎉

---

BTW: The deployment already runs on GHA, instead of Travis.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flip1995 @bors