Skip to content

rustup https://github.com/rust-lang/rust/pull/72342, allow unused_crate_dependencies #5653

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

matthiaskrgr
Copy link
Member

changelog: none

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 27, 2020

📌 Commit 3089c3b has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 27, 2020

⌛ Testing commit 3089c3b with merge 2a2208f...

@phansch
Copy link
Member

phansch commented May 27, 2020

@matthiaskrgr Huh, why would the lint have to be allowed only in these two specific files?

@matthiaskrgr
Copy link
Member Author

I have no idea to be honest :/

@phansch
Copy link
Member

phansch commented May 27, 2020

Weird.. I will try and see if I can reproduce this in the rustc testsuite 🤷‍♂️

@matthiaskrgr
Copy link
Member Author

I wondered if it is perhaps related to the unused lint group but one test allows it while the other one warns on it so I dunno ...

@bors
Copy link
Contributor

bors commented May 27, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 2a2208f to master...

@bors bors merged commit 2a2208f into rust-lang:master May 27, 2020
@phansch
Copy link
Member

phansch commented May 27, 2020

I wondered if it is perhaps related to the unused lint group but one test allows it while the other one warns on it so I dunno ...

Ahh, right 🤦 tests/ui/cognitive_complexity_attr_used.rs was the only of our tests with #![warn(unused)] that's why it triggered only there. I believe the #![allow(unused_crate_dependencies)] in tests/ui/cognitive_complexity.rs is not required either?

@mati865
Copy link
Member

mati865 commented May 28, 2020

Soon will be fixed by rust-lang/rust#72702

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants