Skip to content

CONTRIBUTING: explain how to use cargo dev ra-setup #5661

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 31, 2020

Conversation

matthiaskrgr
Copy link
Member

Fixes #5514

Technically this should be merged after #5655 but it's not very important.


changelog: none

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 28, 2020
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with typos fixed 👍

@phansch phansch added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 29, 2020
@flip1995
Copy link
Member

120 character limit in lines 98 and 100-102.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-bors Status: The marked PR was approved and is only waiting bors labels May 31, 2020
@matthiaskrgr
Copy link
Member Author

Fixed the line length and tried to make the formatting a little less wall-of-text like.

I find it a bit strange that we enforce a max-line width for markdown since it does not actually affect how the text is rendered in the end. 🤔

@bors r=phansch

@bors
Copy link
Contributor

bors commented May 31, 2020

📌 Commit 7727c4a has been approved by phansch

bors added a commit that referenced this pull request May 31, 2020
CONTRIBUTING: explain how to use cargo dev ra-setup

Fixes #5514

Technically this should be merged after #5655 but it's not very important.

---

changelog: none
@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 7727c4a with merge 544d937...

@bors
Copy link
Contributor

bors commented May 31, 2020

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member Author

@bors retry
spurious

@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 7727c4a with merge 6c008d7...

@bors
Copy link
Contributor

bors commented May 31, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 6c008d7 to master...

@bors bors merged commit 6c008d7 into rust-lang:master May 31, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: explain how to get code completion to work when hacking on clippy
5 participants