-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add workspace to manifest #6733
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
9fdbd86
to
745d095
Compare
I went on a long research trait to figure out the build errors. I found dtolnay/trybuild#13 and rust-lang/rust#73603 to be interesting. @Manishearth do you think it is possible that using an up-to-date compiletest would fix the build errors here? Is it feasible to do rust-lang/rust#73603 soon or is that a lot of work? |
Note that there's an active Clippy PR to update our compiletest dependency But I would dearly love to split compiletest out, yes. I think it's feasible but a bunch of work |
Oh! Can you link to it? I suppose I should at least wait for that.
Is there a more feasible version where compiletest is included just like any |
The compiletest update was already merged: #6743 Not sure if it includes the features we want/need for this PR though. |
@camsteffen hmm, unsure about rustc_. It's worth a try, I don't think it will work automatically but it might be doable with some work. But really I feel like it's better for everyone if compiletest is moved out of tree. But you should still feel free to move on making the other thing happen! |
745d095
to
9bcb257
Compare
Excluding mini-macro fixed the build errors. I'm not sure why Excluding clippy-dev is necessary to avoid
|
A possible follow-up change is to change our automated tests to use |
Test workspace at once changelog: none Follow-up to #6733
Whoops didn't mean to pull a fast one but this got merged in #6749 😄 |
@camsteffen @Manishearth This broke Clippy in rust-lang/rust:
|
Argh, I had assumed this would happen but thought people had a reason why it wouldn't given all the discussion. Revert and self-r+ I guess? |
I don't think we can do this. This is the fix, so that dogfood actually is run on Clippy. So we need a solution, not involving |
Remove workspace and fix dogfood (again) changelog: none In response to #6733 (comment)
changelog: none
This fixes the dogfood test to include clippy_lints (regression from #6687).
r? @flip1995