Skip to content

Conversation

Qwaz
Copy link
Contributor

@Qwaz Qwaz commented Dec 4, 2021

PR 1/2 for issue #8045. Add NonNull as a pointer class to suppress false positives like UnsafeCell<NonNull<()>>. However, this change is not sufficient to handle the cases shared in gtk-rs and Rug in the issue.

changelog: none

r? @xFrednet

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 4, 2021
@Qwaz
Copy link
Contributor Author

Qwaz commented Dec 4, 2021

I tried and failed to avoid using hard-coded paths for NonNull. I couldn't find NonNull in diagnostic items. Is there a better way to handle that comparison?

@xFrednet
Copy link
Contributor

xFrednet commented Dec 4, 2021

I tried and failed to avoid using hard-coded paths for NonNull. I couldn't find NonNull in diagnostic items. Is there a better way to handle that comparison?

It sadly doesn't have another identifier besides that. We can add them in the rust repo, but that will take at least a week to be available here again. It's okay to have it like this until we go through them again and add them in rust 🙃

@xFrednet
Copy link
Contributor

xFrednet commented Dec 4, 2021

The changes are looking good, thank you very much! 🙃

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2021

📌 Commit 844996b has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Dec 4, 2021

⌛ Testing commit 844996b with merge 907f6d9...

@bors
Copy link
Contributor

bors commented Dec 4, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 907f6d9 to master...

@bors bors merged commit 907f6d9 into rust-lang:master Dec 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants