Skip to content

Rustup #9516

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 50 commits into from
Sep 29, 2022
Merged

Rustup #9516

merged 50 commits into from
Sep 29, 2022

Conversation

flip1995
Copy link
Member

r? @ghost

changelog: none

Jarcho and others added 30 commits September 6, 2022 14:23
It allows using `LocalDefId` instead of `DefId` when possible, and also encode cheaper `Visibility<DefIndex>` into metadata.
This shrinks `hir::Ty` from 72 to 48 bytes.

`visit_lifetime` is added to the HIR stats collector because these types
are now stored in memory on their own, instead of being within other
types.
This shrinks `hir::Pat` from 88 to 72 bytes.
rustc: Parameterize `ty::Visibility` over used ID

It allows using `LocalDefId` instead of `DefId` when possible, and also encode cheaper `Visibility<DefIndex>` into metadata.
Shrink `hir::Ty` and `hir::Pat`

r? `@ghost`
Allow lint passes to be bound by `TyCtxt`

This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`.

r? rust-lang/compiler
Rollup of 7 pull requests

Successful merges:

 - #98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes)
 - #101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2)
 - #101424 (Adjust and slightly generalize operator error suggestion)
 - #101496 (Allow lower_lifetime_binder receive a closure)
 - #101501 (Allow lint passes to be bound by `TyCtxt`)
 - #101515 (Recover from typo where == is used in place of =)
 - #101545 (Remove unnecessary `PartialOrd` and `Ord`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
rustc_error, rustc_private: Switch to stable hash containers

Relates rust-lang/rust#84447
Use `DisplayBuffer` for socket addresses.

Continuation of rust-lang/rust#100625 for socket addresses.

Renames `net::addr` to `net::addr::socket`, `net::ip` to `net::addr::ip` and `net::ip::display_buffer::IpDisplayBuffer` to `net::addr::display_buffer::DisplayBuffer`.
Simplify visitors more

A successor to #100392.

r? `@cjgillot`
Initial implementation of dyn*

This PR adds extremely basic and incomplete support for [dyn*](https://smallcultfollowing.com/babysteps//blog/2022/03/29/dyn-can-we-make-dyn-sized/). The goal is to get something in tree behind a flag to make collaboration easier, and also to make sure the implementation so far is not unreasonable. This PR does quite a few things:

* Introduce `dyn_star` feature flag
* Adds parsing for `dyn* Trait` types
* Defines `dyn* Trait` as a sized type
* Adds support for explicit casts, like `42usize as dyn* Debug`
  * Including const evaluation of such casts
* Adds codegen for drop glue so things are cleaned up properly when a `dyn* Trait` object goes out of scope
* Adds codegen for method calls, at least for methods that take `&self`

Quite a bit is still missing, but this gives us a starting point. Note that this is never intended to become stable surface syntax for Rust, but rather `dyn*` is planned to be used as an implementation detail for async functions in dyn traits.

Joint work with `@nikomatsakis` and `@compiler-errors.`

r? `@bjorn3`
Clippy pre beta branch fix

Before beta is branched on Friday, I want to move the `unused_peekable` lint  that was added in this release cycle (1.65) to `nursery`. This lint was already reported twice (rust-lang#9456, rust-lang#9462) in a short time, so it is probably a good idea to fix it before it hits beta and then stable.

r? `@Manishearth`
@bors
Copy link
Contributor

bors commented Sep 26, 2022

☔ The latest upstream changes (presumably #9233) made this pull request unmergeable. Please resolve the merge conflicts.

@matthiaskrgr
Copy link
Member

once rust-lang/rust#102378 lands, the ice should be fixed 🎉

@flip1995
Copy link
Member Author

@bors r+

Let's see if it works. Thanks for keeping track of this!

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit d792c3a has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2022

⌛ Testing commit d792c3a with merge 0e9321d...

bors added a commit that referenced this pull request Sep 28, 2022
Rustup

r? `@ghost`

changelog: none
@bors
Copy link
Contributor

bors commented Sep 28, 2022

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member

I think we have to wait for next nightly, the fix was just merged this morning

@flip1995
Copy link
Member Author

Ah right. Let's hope that Clippy won't be touched in the Rust repo until tomorrow :D

@flip1995
Copy link
Member Author

@bors r+

Bumping the nightly version was enough, puh.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

📌 Commit 924c1ce has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

⌛ Testing commit 924c1ce with merge e43f5a1...

@bors
Copy link
Contributor

bors commented Sep 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e43f5a1 to master...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.