Skip to content

Change uninlined_format_args into a style lint #9600

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Oct 6, 2022

As previously discussed, the uninlined_format_args should probably be a part of the default style because println!("{}", foo) is not as concise or easy to understand as println!("{foo}")

changelog: [uninlined_format_args]: change to be the default style

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2022
@llogiq
Copy link
Contributor

llogiq commented Oct 10, 2022

Taking over review from @Alexendoo to reduce his load.

I'd like to see an //edition:2018 test. I personally think the lint should probably not apply there, right?

r? @llogiq

@rust-highfive rust-highfive assigned llogiq and unassigned Alexendoo Oct 10, 2022
@nyurik
Copy link
Contributor Author

nyurik commented Oct 10, 2022

I'd like to see an //edition:2018 test. I personally think the lint should probably not apply there, right?

@llogiq take a look at #9605 -- I tried to add a 2018 edition, and fix the bug with the panic, but somehow the test does not run as 2018th edition - could you see if i need to do something else there to fix it? Thanks!

@llogiq
Copy link
Contributor

llogiq commented Oct 11, 2022

Ok, so I'll try getting #9605 merged first.

@nyurik
Copy link
Contributor Author

nyurik commented Oct 13, 2022

This one is ready to go

@llogiq
Copy link
Contributor

llogiq commented Oct 13, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit 4936848 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 13, 2022

⌛ Testing commit 4936848 with merge 58ef56e...

@bors
Copy link
Contributor

bors commented Oct 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 58ef56e to master...

@bors bors merged commit 58ef56e into rust-lang:master Oct 13, 2022
@nyurik nyurik deleted the inline-fmt-style branch October 13, 2022 13:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants