Skip to content

Shrink missing_{safety,errors,panics}_doc spans #9772

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

lukas-code
Copy link
Member

Shrink the spans of clippy::missing_*_doc to match missing_docs and don't cover the entire item anymore. This helps readability in IDEs by not coloring the entire screen yellow, similar to rust-lang/rust#103749 and rust-lang/rust#90761.

before:
image

after:
image

changelog: [missing_safety_doc], [missing_error_doc], [missing_panics_doc]: These lints no longer span the entire item.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2022

📌 Commit d35b7de has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 2, 2022

⌛ Testing commit d35b7de with merge 647644b...

@bors
Copy link
Contributor

bors commented Nov 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 647644b to master...

@bors bors merged commit 647644b into rust-lang:master Nov 2, 2022
@lukas-code lukas-code deleted the doc-spans branch November 2, 2022 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants