Skip to content

Add thumbv7a-uwp-windows-msvc to platform-support #379

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 13, 2020

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Jun 12, 2020

The target spec for thumbv7a-uwp-windows-msvc was added to the Rust codebase in rust-lang/rust#72133. It should be documented as a Tier 3 target once added.

libstd built and worked out of the box, but some crates built only in --release builds. Therefore, the usability I assume is ?.

@XAMPPRocky
Copy link
Member

Thank you for your PR! I believe it should be * the only requirement is that it builds std afaik.

@bdbai
Copy link
Contributor Author

bdbai commented Jun 13, 2020

Given all core, alloc and std builds, is it suitable to put a ?
image

@XAMPPRocky
Copy link
Member

Yes that seems correct to me.

@bdbai
Copy link
Contributor Author

bdbai commented Jun 13, 2020

Fixed

@XAMPPRocky
Copy link
Member

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 226d928 into rust-lang:master Jun 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants