Skip to content

Add rustdoc team processes #852

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add rustdoc team processes #852

wants to merge 2 commits into from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 21, 2025 •
edited by rustbot
Loading

cc @rust-lang/rustdoc

Rendered

fmease
fmease reviewed May 21, 2025
View reviewed changes
fmease
fmease reviewed May 21, 2025
View reviewed changes
fmease
fmease reviewed May 21, 2025
View reviewed changes
@ehuss
Copy link
Contributor

ehuss commented May 21, 2025

Can you also add the rustdoc team to triagebot.toml for this directory and give yourselves permissions in https://github.com/rust-lang/team/blob/HEAD/repos/rust-lang/rust-forge.toml?

@GuillaumeGomez GuillaumeGomez mentioned this pull request May 21, 2025
Open
aDotInTheVoid
aDotInTheVoid reviewed May 21, 2025
View reviewed changes
Copy link
Member

@aDotInTheVoid aDotInTheVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'm very happy to see this written down.

fmease
fmease reviewed May 21, 2025
View reviewed changes
@fmease fmease added T-rustdoc Team: Rustdoc needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels May 21, 2025
@fmease
Copy link
Member

fmease commented May 21, 2025 •
edited
Loading

(This PR will obviously need a T-rustdoc FCP to make it official once most things have been sufficiently fleshed out)

@fmease fmease added the S-waiting-on-team Status: Awaiting review/feedback/decision from relevant team(s) label May 21, 2025
Manishearth
Manishearth reviewed May 21, 2025
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this seems pretty good!

@GuillaumeGomez
Copy link
Member Author

(This PR will obviously need a T-rustdoc FCP to make it official once most things have been sufficiently fleshed out)

Absolutely!

@GuillaumeGomez
Copy link
Member Author

I added the change in triagebot.toml as suggested by @ehuss.

I went through all comments.

@fmease: Hopefully I clarified that the rustdoc "groups" are not full-fledged teams and as such, to be part of them, you need to be a member of the rustdoc team.

fmease
fmease reviewed May 21, 2025
View reviewed changes
lolbinarycat
lolbinarycat reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@lolbinarycat lolbinarycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

apiraino
apiraino requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment after a cursory read.

Great work @GuillaumeGomez !

src/rustdoc/proposals-and-stabilization.md
### Can I work on code experimentally before a approval is gained?
Of course! You are free to work on PRs or write code. But those PRs should be marked as
experimental and they should not land, nor should anyone be expected to review them (unless
folks want to).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or as draft.

Slightly tangential, there is an ongoing discussion about the overlap between the label S-experimental and the "draft" state that GH offers. I don't know if this discussion is relevant to this bit of documentation, just wanted to mention it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue, might be worth revisiting want this discussion has a conclusion.

@GuillaumeGomez GuillaumeGomez force-pushed the rustdoc branch 2 times, most recently from 4da4ad9 to ab7ee18 Compare May 22, 2025 12:41
notriddle
notriddle reviewed May 22, 2025
View reviewed changes
src/rustdoc/calendar.md
@@ -0,0 +1,3 @@
# Calendar
Rustdoc team's calendar is available in the Rust project's
[`rust-lang/calendar`][calendar_repo] repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link ref not defined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@notriddle notriddle notriddle requested changes

@Manishearth Manishearth Manishearth left review comments

@fmease fmease fmease left review comments

@lolbinarycat lolbinarycat lolbinarycat left review comments

@aDotInTheVoid aDotInTheVoid aDotInTheVoid left review comments

@apiraino apiraino apiraino requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-team Status: Awaiting review/feedback/decision from relevant team(s) T-rustdoc Team: Rustdoc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @ehuss @fmease @notriddle @Manishearth @apiraino @lolbinarycat @aDotInTheVoid