Bump to clap 3 #114
Merged
Bump to clap 3 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Jul 9, 2022
This includes the following pull requests: * rust-lang/rust-installer#114 * rust-lang/rust-installer#113
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 10, 2022
…mulacrum Bump to clap 3 This PR, along with several others, will entirely remove the Clap 2 dependency from the rust source tree. * rust-lang/rust-installer#114 * rust-lang/rls#1779 This PR includes a submodule bump for rust-installer, which includes the following PRs: * rust-lang/rust-installer#114 * rust-lang/rust-installer#113 * rust-lang/rust-installer#115
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches
fabricate's arg parsing from the now-deprecated YAML-based system to the now-standard derive-based Clap API, as described here: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#300---2021-12-31.Along with several other PRs, this will remove all dependencies on clap 2 from the rust source tree.