Auto merge of #80831 - jyn514:no-inline, r=Mark-Simulacrum

bors · bors · commit 7cf205610e13 · 2021-01-10T01:08:41.000Z
Don't mark `force_query_with_job` as `inline(always)` It's rather large, and using `inline(always)` forces it to be recompiled in each calling crate. Hopefully this change will help with #65031. I intentionally only removed inline from `force_query_with_job` because the other functions are tiny and I wanted to measure this change on its own. This may conflict with #78780. I am not sure if it will hurt or help. cc `@cjgillot`
diff --git a/compiler/rustc_query_system/src/query/plumbing.rs b/compiler/rustc_query_system/src/query/plumbing.rs
@@ -566,7 +566,6 @@ fn incremental_verify_ich<CTX, K, V>(
     assert!(new_hash == old_hash, "found unstable fingerprints for {:?}", dep_node,);
 }
 
-#[inline(always)]
 fn force_query_with_job<C, CTX>(
     tcx: CTX,
     key: C::Key,

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,6 @@ fn incremental_verify_ich<CTX, K, V>(`
`566`	`566`	`assert!(new_hash == old_hash, "found unstable fingerprints for {:?}", dep_node,);`
`567`	`567`	`}`
`568`	`568`
`569`		`-#[inline(always)]`
`570`	`569`	`fn force_query_with_job<C, CTX>(`
`571`	`570`	`tcx: CTX,`
`572`	`571`	`key: C::Key,`