Skip to content

Don't mark force_query_with_job as inline(always) #80831

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 8, 2021

It's rather large, and using inline(always) forces it to be recompiled
in each calling crate. Hopefully this change will help with #65031. I intentionally only removed inline from force_query_with_job because the other functions are tiny and I wanted to measure this change on its own.

This may conflict with #78780. I am not sure if it will hurt or help.

cc @cjgillot

It's rather large, and using `inline(always)` forces it to be recompiled
in each calling crate.
@jyn514 jyn514 added I-compiletime Issue: Problems and improvements with respect to compile times. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Jan 8, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jan 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

⌛ Trying commit 0215b3a with merge 655c9806c84395e29badb25684a35e1e2971f29e...

@bors
Copy link
Collaborator

bors commented Jan 9, 2021

☀️ Try build successful - checks-actions
Build commit: 655c9806c84395e29badb25684a35e1e2971f29e (655c9806c84395e29badb25684a35e1e2971f29e)

@rust-timer
Copy link
Collaborator

Queued 655c9806c84395e29badb25684a35e1e2971f29e with parent 26438b4, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (655c9806c84395e29badb25684a35e1e2971f29e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jan 9, 2021

Up to -3.9% on bootstrap time. Up to +.4% on doc timings, which seems fine. Other changes look like noise.

@Mark-Simulacrum
Copy link
Member

@bors r+

Seems like a good win, potentially very minor regression in compile times but pretty sizeable win to bootstrap time (1.5% overall).

@bors
Copy link
Collaborator

bors commented Jan 9, 2021

📌 Commit 0215b3a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2021
@bors
Copy link
Collaborator

bors commented Jan 10, 2021

⌛ Testing commit 0215b3a with merge 7cf2056...

@bors
Copy link
Collaborator

bors commented Jan 10, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7cf2056 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2021
@bors bors merged commit 7cf2056 into rust-lang:master Jan 10, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 10, 2021
@bors bors mentioned this pull request Jan 10, 2021
@jyn514 jyn514 deleted the no-inline branch January 10, 2021 04:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) I-compiletime Issue: Problems and improvements with respect to compile times. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants