-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Don't mark force_query_with_job
as inline(always)
#80831
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
It's rather large, and using `inline(always)` forces it to be recompiled in each calling crate.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit 0215b3a with merge 655c9806c84395e29badb25684a35e1e2971f29e... |
☀️ Try build successful - checks-actions |
Queued 655c9806c84395e29badb25684a35e1e2971f29e with parent 26438b4, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (655c9806c84395e29badb25684a35e1e2971f29e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Up to -3.9% on bootstrap time. Up to +.4% on doc timings, which seems fine. Other changes look like noise. |
@bors r+ Seems like a good win, potentially very minor regression in compile times but pretty sizeable win to bootstrap time (1.5% overall). |
📌 Commit 0215b3a has been approved by |
☀️ Test successful - checks-actions |
It's rather large, and using
inline(always)
forces it to be recompiledin each calling crate. Hopefully this change will help with #65031. I intentionally only removed inline from
force_query_with_job
because the other functions are tiny and I wanted to measure this change on its own.This may conflict with #78780. I am not sure if it will hurt or help.
cc @cjgillot