Skip to content

hashbrown tests crash on wine #101474

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Amanieu opened this issue Sep 6, 2022 · 4 comments · Fixed by #101476
Closed

hashbrown tests crash on wine #101474

Amanieu opened this issue Sep 6, 2022 · 4 comments · Fixed by #101476

Comments

@Amanieu
Copy link
Member

Amanieu commented Sep 6, 2022

When running cargo test --target x86_64-pc-windows-gnu on a Linux system with Wine installed, the tests crash with:

wine: Unhandled page fault on read access to 0000000000000081 at address 00000002D4D43703 (thread 010c), starting debugger...

Bisecting points to 9208625, I suspect the root cause might be #101325.

cc @ChrisDenton
@Amanieu Amanieu mentioned this issue Sep 6, 2022
Merged
@Amanieu
Copy link
Member Author

Amanieu commented Sep 6, 2022

I couldn't get a proper backtrace due to a different bug (in wine, not in rust) where winedbg fails to parse our debuginfo and crashes.

@ChrisDenton
Copy link
Member

Ah, I think this is to do with the use of a pseduo-handle instead of a real handle (which is unsupported in WINE). I'll patch asap.

@ChrisDenton ChrisDenton mentioned this issue Sep 6, 2022
Merged
@JustForFun88 JustForFun88 mentioned this issue Sep 7, 2022
Closed
@glandium
Copy link
Contributor

glandium commented Sep 7, 2022

I'm observing similar crashes on whatever version of Windows Server is used on Firefox CI.

@ChrisDenton
Copy link
Member

A fix has been posted. Just pending approval.

@JustForFun88 JustForFun88 mentioned this issue Sep 7, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Sep 7, 2022
@Dylan-DPC
Rollup merge of rust-lang#101476 - ChrisDenton:BCryptRandom-fix, r=th…
5a89c6c 
…omcc

Open a BCrypt algorithm handle

Fixes rust-lang#101474, supplants rust-lang#101456.

Replaces use of a pseduo handle with manually opening a algorithm handle.

Most interesting thing here is the atomics.

r? `@thomcc`
@bors bors closed this as completed in 9682b5d Sep 7, 2022
@thomcc thomcc mentioned this issue Oct 23, 2022
Closed
@josephlr josephlr mentioned this issue Oct 26, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open a BCrypt algorithm handle ChrisDenton/rust
3 participants
@Amanieu @glandium @ChrisDenton