Skip to content

Decouple is_rust_llvm from whether LLVM is in-tree or not #102560

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jyn514 opened this issue Oct 2, 2022 · 1 comment · Fixed by #119556
Closed

Decouple is_rust_llvm from whether LLVM is in-tree or not #102560

jyn514 opened this issue Oct 2, 2022 · 1 comment · Fixed by #119556
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Milestone
1.65.0

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 2, 2022

The point of is_rust_llvm is to know whether it contains Rust patches. In #101072 @tmandry added a config option so you can use a vanilla upstream LLVM without affecting other parts of how bootstrap works, this breaks that by re-coupling the idea of "is patched" to "is in tree".

Originally posted by @tmandry in #101833 (comment)
@jyn514 jyn514 added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 2, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 2, 2022
@tmandry
Copy link
Member

tmandry commented Oct 2, 2022

Thanks for filing this! #101072 is on beta, so

@rustbot label: -regression-from-stable-to-nightly

I guess we use milestones for issues like this?

@rustbot rustbot removed the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Oct 2, 2022
@tmandry tmandry added this to the 1.65.0 milestone Oct 2, 2022
@jyn514 jyn514 added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Oct 2, 2022
@jyn514 jyn514 mentioned this issue Oct 2, 2022
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Oct 29, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Oct 31, 2022
@Dylan-DPC
Rollup merge of rust-lang#103732 - Mark-Simulacrum:revert-compiler-bu…
3affb05 
…iltins, r=jyn514

Revert "Make the `c` feature for `compiler-builtins` opt-in instead of inferred"

This reverts commit 3acb505 (PR rust-lang#101833).

The changes in this commit caused several bugs/incompatibilities (rust-lang#101833 (comment), rust-lang#102560). For now we're reverting this commit and will re-land it alongside fixes for those bugs.

Re-opens rust-lang#101172
cc rust-lang#102560
cc rust-lang#102579
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 9, 2022
jyn514 added a commit to jyn514/rust that referenced this issue Nov 25, 2022
@jyn514
Distinguish "has patches" from "in-tree" again
a142760 
Fixes rust-lang#102560
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 9, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 9, 2022
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 18, 2023
@jyn514 jyn514 mentioned this issue Mar 10, 2023
Closed
jyn514 added a commit to jyn514/rust that referenced this issue Jul 8, 2023
@jyn514
Distinguish "has patches" from "in-tree" again
b33de79 
Fixes rust-lang#102560
@onur-ozkan onur-ozkan mentioned this issue Jan 3, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#119556 - onur-ozkan:optimized-compiler-buil…
b889dd5 
…tins, r=onur-ozkan

Reland optimized-compiler-builtins config

Copy of rust-lang#102579 PR.

From rust-lang#102579:

> No concerns on my side. Currently, Jyn isn't actively working on the project. I will close this PR; open another one to cherry-pick the commits, resolve conflicts, and then r+ it.

> Fixes rust-lang#102560. Fixes rust-lang#101172. Helps with rust-lang#105065 (although there's some weirdness there - it's still broken when optimized-compiler-builtins is set to true).

Fixes rust-lang#102560. Fixes rust-lang#101172. Helps with rust-lang#105065

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 7, 2024
@bors
Auto merge of rust-lang#119556 - onur-ozkan:optimized-compiler-builti…
87e1430 
…ns, r=onur-ozkan

Reland optimized-compiler-builtins config

Copy of rust-lang#102579 PR.

From rust-lang#102579:

> No concerns on my side. Currently, Jyn isn't actively working on the project. I will close this PR; open another one to cherry-pick the commits, resolve conflicts, and then r+ it.

> Fixes rust-lang#102560. Fixes rust-lang#101172. Helps with rust-lang#105065 (although there's some weirdness there - it's still broken when optimized-compiler-builtins is set to true).

Fixes rust-lang#102560. Fixes rust-lang#101172. Helps with rust-lang#105065

r? ghost
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jan 10, 2024
@bors
Auto merge of #119556 - onur-ozkan:optimized-compiler-builtins, r=onu…
192cf3b 
…r-ozkan

Reland optimized-compiler-builtins config

Copy of #102579 PR.

From #102579:

> No concerns on my side. Currently, Jyn isn't actively working on the project. I will close this PR; open another one to cherry-pick the commits, resolve conflicts, and then r+ it.

> Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065 (although there's some weirdness there - it's still broken when optimized-compiler-builtins is set to true).

Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065

r? ghost
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@bors
Auto merge of #119556 - onur-ozkan:optimized-compiler-builtins, r=onu…
048daa5 
…r-ozkan

Reland optimized-compiler-builtins config

Copy of #102579 PR.

From #102579:

> No concerns on my side. Currently, Jyn isn't actively working on the project. I will close this PR; open another one to cherry-pick the commits, resolve conflicts, and then r+ it.

> Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065 (although there's some weirdness there - it's still broken when optimized-compiler-builtins is set to true).

Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065

r? ghost
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #119556 - onur-ozkan:optimized-compiler-builtins, r=onu…
c49e0c4 
…r-ozkan

Reland optimized-compiler-builtins config

Copy of #102579 PR.

From #102579:

> No concerns on my side. Currently, Jyn isn't actively working on the project. I will close this PR; open another one to cherry-pick the commits, resolve conflicts, and then r+ it.

> Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065 (although there's some weirdness there - it's still broken when optimized-compiler-builtins is set to true).

Fixes rust-lang/rust#102560. Fixes rust-lang/rust#101172. Helps with rust-lang/rust#105065

r? ghost
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.65.0
5 participants
@tmandry @Mark-Simulacrum @apiraino @jyn514 @rustbot