Skip to content

Notable traits tooltip is laid out underneath subsequent methods #102576

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Alexendoo opened this issue Oct 2, 2022 · 0 comments · Fixed by #104129
Closed

Notable traits tooltip is laid out underneath subsequent methods #102576

Alexendoo opened this issue Oct 2, 2022 · 0 comments · Fixed by #104129
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Alexendoo
Copy link
Member

This happens because contain: layout (#102253) establishes a new stacking context

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/hir/map/struct.Map.html#method.parent_owner_iter
parent_iter's notable trait tooltip underflowing is_lhs
@Alexendoo Alexendoo added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Oct 2, 2022
@notriddle notriddle mentioned this issue Nov 7, 2022
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
4cd7c67 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
3a2ab4e 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
7531c2b 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 10, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
e28498e 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
9d0aed9 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
206928c 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
16b8651 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Nov 11, 2022
@Dylan-DPC
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
1f51fbe 
…ble-trait, r=GuillaumeGomez

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
b74d042 
…ble-trait, r=Manishearth

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
@bors bors closed this as completed in 303653e Nov 11, 2022
@Nemo157 Nemo157 mentioned this issue Jan 4, 2023
Closed
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@Manishearth
Rollup merge of rust-lang#104129 - notriddle:notriddle/102576-js-nota…
5227295 
…ble-trait, r=Manishearth

rustdoc: use javascript to layout notable traits popups

Fixes rust-lang#102576

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
@notriddle notriddle mentioned this issue Jun 1, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: use javascript to layout notable traits popups notriddle/rust
1 participant
@Alexendoo